Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Participant data not being returned #1755

Open
happy5214 opened this issue Jul 25, 2023 · 3 comments · May be fixed by #1772
Open

Participant data not being returned #1755

happy5214 opened this issue Jul 25, 2023 · 3 comments · May be fixed by #1772

Comments

@happy5214
Copy link
Collaborator

I'm currently trying to add support for HED validation in participants.tsv files, and I'm running into an issue getting the participant data passed to HED. First of all, it seems the participants object doesn't include the full row, but I can't even use that data because I'm just getting null when I try to access it (the main point of this issue). I've tried it on the fmri_ds002790s_hed_aomic hed-examples dataset, which clearly has a participants.tsv, to no avail.
@sappelhoff
Copy link
Member

cc @rwblair

@VisLab
Copy link
Member

VisLab commented Jul 31, 2023

Just a few extra comments:

  1. The dataset above is fmri_ds002790s_hed_aomic.
  2. We noticed that if we removed a line from the participants.tsv file that error 40 wasn't being thrown indicating that a subject was missing an entry in the participants file.

@happy5214
Copy link
Collaborator Author

happy5214 commented Aug 4, 2023 •
edited

The assignment in

bids-validator/bids-validator/validators/tsv/validate.js

Line 40 in 6fc6d15

participants = {
is not showing up upon returning to fullTest. null is passed as the value of participants into the function, so perhaps the assignment is being ignored? (Is null passed by value?) The assignment in

bids-validator/bids-validator/validators/tsv/validate.js

Line 45 in 6fc6d15

participantsTsvContent = contents
seems to work, so the code is being executed.

@rwblair

@rwblair rwblair linked a pull request Aug 8, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Participants data always null. Issue 49 never thrown. rwblair/bids-validator
3 participants
@VisLab @happy5214 @sappelhoff