Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] apply derivative definition to qMRI #1813

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[ENH] apply derivative definition to qMRI #1813

wants to merge 9 commits into from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented May 6, 2024 •
edited

@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (0950f6d) to head (a653a18).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1813   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          16       16           
  Lines        1375     1375           
=======================================
  Hits         1209     1209           
  Misses        166      166

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

effigies
effigies reviewed May 6, 2024
View reviewed changes
src/appendices/qmri.md Outdated Show resolved Hide resolved
Remi-Gau
Remi-Gau commented May 6, 2024
View reviewed changes
src/appendices/qmri.md Outdated Show resolved Hide resolved
effigies
effigies reviewed May 6, 2024
View reviewed changes
src/appendices/qmri.md Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau requested a review from agahkarakuzu May 6, 2024 13:33
effigies
effigies reviewed May 6, 2024
View reviewed changes
src/appendices/qmri.md Outdated Show resolved Hide resolved
src/appendices/qmri.md Outdated Show resolved Hide resolved
src/schema/objects/common_principles.yaml Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau marked this pull request as ready for review May 6, 2024 13:39
Remi-Gau and others added 5 commits May 6, 2024 15:39
@Remi-Gau @effigies
Update src/appendices/qmri.md
ff1111f 
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@Remi-Gau @effigies
Update src/appendices/qmri.md
f9ac6f3 
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@Remi-Gau @effigies
Update src/appendices/qmri.md
3599642 
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@Remi-Gau
shorten comments
a53270b
@Remi-Gau
revert move of def
a653a18
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented May 7, 2024

Will create a companion PR to modify a couple of bids example to make that the validator has got something to sink its teeth into.

@Remi-Gau Remi-Gau mentioned this pull request May 8, 2024
Merged
@effigies effigies added this to the 1.10.0 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@agahkarakuzu agahkarakuzu Awaiting requested review from agahkarakuzu

@tsalo tsalo Awaiting requested review from tsalo

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

update qMRI to align with the new definition of derivatives
2 participants
@Remi-Gau @effigies