Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Where are physio files placed when simultaneously recording (e.g. fMRI + EEG) #1753

Open
oesteban opened this issue Mar 28, 2024 · 2 comments
Labels
bug Something isn't working physio

Comments

@oesteban
Copy link
Collaborator

Describe your problem in detail.

@effigies caught this issue while working on #1750 (https://github.com/bids-standard/bids-specification/pull/1750/files#r1541231904).

At the moment, the specs are quite unclear regarding where the physio recordings should be placed when they correspond to experiments where more than one single modality was obtained (e.g., fMRI and EEG).

Some solutions have been brainstormed, but this probably requires more visibility than a loose thread within a PR fixing something different.

Describe what you expected.

A clear exposition of what to do in such cases.

BIDS specification section

No response

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Apr 2, 2024

My hot take on this.

Simultaneous recordings are usually "signified" / "detectable" by a proper use of scans.tsv where 2 files acquired at the same time will have the same acquisition time value.

If one of those datafile has a companion physio files, it should follow that the physio file should be valid for the other datatype.

I would say that even if my hot take is correct, this is nowhere explained in any of our doc.

@effigies
Copy link
Collaborator

effigies commented Apr 2, 2024

I thought at one point there was guidance about simultaneous EEG/fMRI, but I don't know where it is, now. It is beyond the spec, in any case, and it seems unlikely that tools will depend on detecting it as opposed to just assuming it.

Either way, I would expect these files to have a common set of entities (sub, ses, task, run), which would allow them to find the associated physio.tsv.gz via the inheritance principle if it were pulled outside the func/ or eeg/ directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working physio
Projects
None yet
Development

No branches or pull requests

3 participants