Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Allow to keep heading of admonition in PDF #1768

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Apr 11, 2024

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (591eebb) to head (c9971d9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1768   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau
Copy link
Collaborator Author

Should only affect the PDF.

image

image

@Remi-Gau Remi-Gau marked this pull request as ready for review April 11, 2024 12:56
@effigies
Copy link
Collaborator

I don't love how this looks, as the connection between the header and content isn't clear. Perhaps we could look into using existing pandoc tooling instead of hacking our own thing?

@Remi-Gau
Copy link
Collaborator Author

@Remi-Gau Remi-Gau added exclude-from-changelog This item will not feature in the automatically generated changelog formatting Aesthetics and formatting of the spec labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog formatting Aesthetics and formatting of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve admonition handling code
2 participants