Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify data formats for imaging data (MRI, microscopy, ...), remove MRI-centric language from common principles #1713

Open
nbeliy opened this issue Feb 26, 2024 · 9 comments · May be fixed by #1720
Labels
consistency Spec is (potentially) inconsistent data format

Comments

@nbeliy
Copy link

nbeliy commented Feb 26, 2024

Dear developers,

I can't find an explicit format requirements for MRI.

All examples/templates implies Nifti format with one file (.nii). Will the Nifti 2 files (.hdr+.img) will also compatible with BIDS? Same question for DICOM images.

If BIDS restrict the file formats for MRI (similar to EEG restrictions), can these restrictions introduced into documentation?

P.S. Similar issue exists for PET, there is explicit mention of Nifti file, but without precision of one-file schema (.nii).

@sappelhoff
Copy link
Member

It's under Common Principles:

All imaging data MUST be stored using the NIfTI file format.

https://bids-specification.readthedocs.io/en/latest/common-principles.html#imaging-files

where exactly would you have expected this information to be instead?

Will the Nifti 2 files (.hdr+.img) will also compatible with BIDS

I don't think so

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Feb 26, 2024

For DICOM I would redirect people towards this discussion / draft proposal

#1551

@nbeliy
Copy link
Author

nbeliy commented Feb 27, 2024

It's under Common Principles:

Indeed, didn't fought to look there. But it will be better to place it into MRI explicitly. Other modalities provide the format in which data is expected.

Also, it leads to contradiction (saw it just now):

Common Principles:

All imaging data MUST be stored using the NIfTI file format. We RECOMMEND using compressed NIfTI files (.nii.gz), either version 1.0 or 2.0.

Microscopy:

Microscopy raw data MUST be stored in one of the following formats:
Portable Network Graphics (.png)
Tag Image File Format (.tif)
OME-TIFF (.ome.tif for standard TIFF files or .ome.btf for BigTIFF files)
OME-ZARR/NGFF (.ome.zarr directories)

I guess MRI was written first, when imaging data meant MRI only.

@sappelhoff
Copy link
Member

I guess MRI was written first, when imaging data meant MRI only.

That is true. I think we should adjust this, thanks for bringing it up.

@Remi-Gau
Copy link
Collaborator

I agree that this section should better live under the datatype specific sections: namely MRI and PET (for now but with MRS soon).

I usually do not like duplication but in this case, I think most users will have the same expectation as @nbeliy on this one.

Plus we can macroify this if we want to avoid duplication.

@Remi-Gau
Copy link
Collaborator

@nbeliy do you feel like opening a PR for this one?

@sappelhoff sappelhoff changed the title No explicit requirements on data format for MRI data Clarify data formats for imaging data (MRI, microscopy, ...), remove MRI-centric language from common principles Feb 27, 2024
@sappelhoff sappelhoff added the consistency Spec is (potentially) inconsistent label Feb 27, 2024
@nbeliy
Copy link
Author

nbeliy commented Feb 27, 2024

Will try, but will need an editor, I'm very dyslexic.

Just to be clear:

  1. I would remove image data format from Common principles (also check if there some other MRI specific stuff).
  2. I would add Data format section into MRI
  3. Add annex with data formats table for all defined modalities

Is it good for you?

@Remi-Gau
Copy link
Collaborator

Will try, but will need an editor, I'm very dyslexic.

No worries, codespell will do a first pass and we (maintainers) will help you along.

Just to be clear:

1. I would remove image data format from Common principles (also check if there some other MRI specific stuff).

yes

2. I would add Data format section into MRI

Given that Nifti are used for PET as well it will have to be added in the PET page too.

3. Add annex with data formats table for all defined modalities

I would say: let's start simple and keep that for another PR. Though I think some kind of summary table would indeed be welcome especially given the growing list of datatypes BIDS support.

Most likely this kind of table could actually be generated using the BIDS schema and some python code to create the table automatically. But as I said: let's keep that for another PR.

@nbeliy nbeliy linked a pull request Mar 5, 2024 that will close this issue
1 task
@nbeliy
Copy link
Author

nbeliy commented Mar 5, 2024

Started the PR (#1720)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Spec is (potentially) inconsistent data format
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants