Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descriptions.tsv not fully supported in schema #1710

Open
tsalo opened this issue Feb 22, 2024 · 0 comments
Open

descriptions.tsv not fully supported in schema #1710

tsalo opened this issue Feb 22, 2024 · 0 comments
Labels
bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release.

Comments

@tsalo
Copy link
Member

tsalo commented Feb 22, 2024

There are two problems I wasn't able to address in #1707:

  1. The filename template-building macro isn't working. This is because the descriptions.tsv file has unique rules, unlike other files in the schema. Namely, it can appear at the top level of the dataset, or in subject-level folders, or in session-level folders, but not in datatype-level folders.
    • I think trying to support subject-level and session-level descriptions is probably unnecessary, and overcomplicates things.
  2. Rules/checks not implemented in schema.
    • We probably want to warn users if any descriptions in the TSV file aren't reflected in the dataset, or vice versa, but I couldn't figure out how to actually implement this in the schema, nor in the validator.

Originally posted by @tsalo in #1707 (comment)

@tsalo tsalo added bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release. labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

No branches or pull requests

1 participant