UpdateCallIn("Shutdown") makes widget removal fail when widget:Shutdown throws an error

[MasterBel2]

Usually, if widget:Shutdown() errors, the widget is successfully removed and can be fully disabled.

Example code:

function widget:GetInfo()
    return {
        name = "Test Shutdown Error (Standard)"
    }
end

local DeferredInit

function widget:Update()
    error()
end

function widget:Shutdown()
    Spring.Echo("Normal Shutdown")
    error()
end

However, if you update the Shutdown callin after init, e.g. when deferring your init until after another widget loads, widget removal fails. The widget selector will show the widgets name in yellow (as when you call widgetHandler:RemoveWidget(self) or when the widget errors out normally), however clicking on the widgets name will not fully disable it (turn it red) and errors will continue to be thrown.

Error message: [t=00:00:29.658501][f=-000001] Error: [LuaUI::RunCallInTraceback] error=2 (LUA_ERRRUN) callin=Update trace=[Internal Lua error: Call failure] [No traceback returned]

Example code:

function widget:GetInfo()
    return {
        name = "Test Shutdown Error (Deferred Init)"
    }
end

local DeferredInit

function widget:Update()
    if DeferredInit then 
        DeferredInit(widget)
        DeferredInit = nil

        error()
    end
end

function widget:Initialize()
    DeferredInit = function(widget)
        function widget:Shutdown()
            Spring.Echo("Deferred Init Shutdown")
            error() -- if this error is not thrown, there is no issue with widget removal
        end

        widgetHandler:UpdateCallIn("Shutdown")
    end
end

[MasterBel2]

Haha I took another look at this and seems I was fully mistaken on whats actually going on. Lemme close this until I work it out

[MasterBel2]

Ok, no, the issue is a thing, I just confused myself. Time to take a break lol