Handle hash commands such as HGETALL in redis processor #2597
+118
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kysel <code@martinkysel.com>
mkysel
force-pushed
the
mkysel/redis-processor
branch
from
2ba26af
to
9747848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crux of the reported issue was that https://github.com/benthosdev/benthos/blob/main/public/service/message.go#L262 requires an array of
[string]anybut the redis library returns[any]anywhich does not get processed right.Once all the types are cast to string, it behaves as expected.
Added unit tests for HSet HGet and HGetAll.
All existing Redis unit tests pass.
Fixes #2282