Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEST - requested modifications to fedvoc #32

Open
MarcBruyland opened this issue Apr 22, 2024 · 1 comment
Open

BEST - requested modifications to fedvoc #32

MarcBruyland opened this issue Apr 22, 2024 · 1 comment

Comments

@MarcBruyland
Copy link
Contributor

2024-04-22 Mail Eddy Corthouts (PM project BEST):

Voor enkele definities in fedvoc zou het BeSt team volgende aanpassingen willen voorstellen:

1/ namespace

Weglaten eerste zin.
In de 2e zin “object” toevoegen tussen “same” en “identifier”, dus “same object identifier”
image

2/ Object identifier

Huidige definitie
image

Voorstel aangepaste definitie: “a number uniquely identifying the object within the namespace”

3/ Class Adress

Huidige definitie
image

Voorstel aangepaste definitie:

“An address is a spatial object that in a human readable way identifies a fixed location of a property (building, parcel, …). For this purpose, an address has an identifier, e.g. an address number, which enables a user to distinguish it from the neighbor addresses, as well as a geographic position, which enables an application to locate the address spatially.”

@pvdbosch
Copy link
Contributor

From what I've learned about BEST identifiers, I wonder if we really need to describe the different parts of the identifier separately?

Each addressable object could just be identified by a single globally unique URI (string) that's internally composed of namespace+object+version.
This could be compliant to ICEG standards and simplify representation by having a single string instead of a triplet of parameters.

If we expose the identifier's components, we risk mixing business data with identification, which is not a good practice (e.g. birth date and gender in SSIN).
Because regions handle versioning differently, mutations should be modeled explicitly in a data model and exposed through APIs instead of implicitly from identifiers.

Aside from this discussion:

  • do we want to mandate number format for parts of the identifier? If not, I'd just talk about "identifier" instead of "number".
  • "which enables a user to distinguish it from the neighbor addresses," => "... distinguish it from other Belgian addresses" (not only the neighboring ones)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants