Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of MRCA heights in a starting tree appears to be wrong #1095

Open
davidcerny opened this issue Sep 26, 2020 · 0 comments
Open

Calculation of MRCA heights in a starting tree appears to be wrong #1095

davidcerny opened this issue Sep 26, 2020 · 0 comments
Labels

Comments

@davidcerny
Copy link

davidcerny commented Sep 26, 2020

On macOS 10.15.6 using BEAST v1.10.4 #bc6cbd9, the XML file linked below (generated using the corresponding version of BEAUti) runs when the prior placed on Calibration14 (line 32534) is normal, or when it is exponential with an offset of up to 18.0. However, it produces a negative infinity in the BooleanLikelihood component of the posterior when the offset is at least 18.0625. This would suggest that the height of the corresponding node in the starting tree is in [18.0,18.0625], so that the tree as a whole is assigned a nonzero prior density under the lower offset but not the higher one.

However, the actual height of the MRCA of the five taxa (lines 754--758) comprising the taxon set of Calibration14 in the starting tree (line 31082) is 34.3569. I verified it using phytools::nodeheight() in R and FigTree. A quick check with phytools shows that there are no nodes with a height between 18.0 and 18.0625 in the starting tree at all. There seems to be something wrong with the way the newick string of the starting tree is being processed.

http://drive.google.com/file/d/1ORqF15zADcWz-IRaBksURdFN_O-Gppv2

@rambaut rambaut added the bug label Apr 27, 2023
@rambaut rambaut added this to the v.1.10.5 milestone Apr 27, 2023
@rambaut rambaut removed this from the v.1.10.5 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants