Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestValidateFormat fails in 1.2.3 #39

Open
QuLogic opened this issue Jul 12, 2021 · 3 comments
Open

TestValidateFormat fails in 1.2.3 #39

QuLogic opened this issue Jul 12, 2021 · 3 comments

Comments

@QuLogic
Copy link

QuLogic commented Jul 12, 2021

This used to pass in 1.2.1:

$ go test -run TestValidateFormat
--- FAIL: TestValidateFormat (0.00s)
    checkmail_test.go:94: " florian@carrere.cc" => expected error
    checkmail_test.go:94: "florian@carrere.cc " => expected error
    checkmail_test.go:94: " test@gmail.com" => expected error
FAIL
FAIL	github.com/badoux/checkmail	0.003s
FAIL
@QuLogic
Copy link
Author

QuLogic commented Jul 12, 2021 •
edited

Bisect says 9c951e8 or #31 (but there were many build failures in between, so may or may not be true.)

@bensie
Copy link

bensie commented Feb 15, 2022

I'm seeing the same issue - the regexp change causes the failure.

@QuLogic
Copy link
Author

QuLogic commented Feb 3, 2024

Still broken in 1.2.4 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensie @QuLogic