Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NPM Unpacked Size by version #10059

Open
adamlui opened this issue Apr 1, 2024 · 0 comments
Open

Allow NPM Unpacked Size by version #10059

adamlui opened this issue Apr 1, 2024 · 0 comments

Comments

@adamlui
Copy link

adamlui commented Apr 1, 2024

The GitHub File Size shield allows a param for branch so a version tag can be supplied. This is useful since users can be viewing readme's from specific releases on github.com, so the size should reflect what they're actually downloading.

The same should apply to NPM Unpacked Size (but by version) because when packages are published, npmjs.com renders the README for that release, so if it contains this shield, it wrongly shows the size for latest package only, so user can end up browsing version history for an older release to download, for example:

image
image
image

... yet they all show the same unpacked size for all the releases, so it is misleading. They might be looking for an older version specifically for smallest unpacked size that provides the minimal feature set they actually require for their project.

This is also useful on github.com where there's no true unpacked size in sidebar like npmjs.com to correct the untrue shield info

@adamlui adamlui changed the title NPM Unpacked Size by version Allow NPM Unpacked Size by version Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant