Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #231: Fix 'version' command bug #232

Merged
merged 2 commits into from Jan 24, 2021
Merged

Issue #231: Fix 'version' command bug #232

merged 2 commits into from Jan 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2020

Fixes #231

@ghost ghost mentioned this pull request Nov 15, 2020
Open
@serundeputy
Copy link
Member

thanks @BWPanda

this did not work for me:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   632  100   632    0     0   3001      0 --:--:-- --:--:-- --:--:--  3009
100 4879k  100 4879k    0     0  4771k      0  0:00:01  0:00:01 --:--:-- 6757k
Command backdrop-drush-version needs a higher bootstrap level to run - you will need to invoke drush from a more functional Drupal environment to run this command.                                                                                  [error]
The drush command 'version' could not be executed.                                                                                                                                                                                                   [error]
ERROR ==> The drush command 'version' could not be executed.                                                                                                                                                                                                   [error]

@ghost
Copy link
Author

ghost commented Nov 17, 2020

@serundeputy I wasn't sure how to test this with Lando... But it does fix the more general problem described in the linked issue.

@klonos
Copy link
Member

klonos commented Jan 9, 2021

Hey @BWPanda and @serundeputy 👋 ...I guess #233 is an attempt to fix the test failures. Right? ...otherwise, it seems to be @BWPanda's PR + a commit to revert composer to 1.x in .travis.yml.

@ghost
Copy link
Author

ghost commented Jan 9, 2021

@klonos Seems that way...

@ghost
Copy link
Author

ghost commented Jan 24, 2021

I changed the bootstrap for the 'version' command from DRUSH_BOOTSTRAP_DRUSH (which is only used in one other place - grn.drush.inc) to DRUSH_BOOTSTRAP_NONE (which is used in 5 other places. Hopefully this makes it easier to understand what this line means.

@klonos klonos merged commit 00da8d9 into backdrop-contrib:1.x-1.x Jan 24, 2021
@ghost ghost deleted the patch-1 branch January 24, 2021 19:41
@ghost ghost mentioned this pull request Jan 25, 2021
Closed
@ghost ghost mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'version' bootstrap issue
2 participants
@serundeputy @klonos