Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port views drush commands #190

Open
klonos opened this issue Jul 26, 2019 · 3 comments
Open

Port views drush commands #190

klonos opened this issue Jul 26, 2019 · 3 comments

Comments

@klonos
Copy link
Member

klonos commented Jul 26, 2019

As mentioned in backdrop/backdrop-issues#3729

As part of the tasks in #3719, we need to account for this issue in Views 7.x, and this respective commit.

It seems that we have removed the /drush directory from our version of views, so where should that code live now? Do we support this in https://github.com/backdrop-contrib/drush ??

...to which @quicksketch replied:

Yes, any core-specific commands should be moved into the backdrop-contrib drush project. Note at the time we ported Views into Backdrop, there was no backdrop-contrib/drush. So all commands are probably missing an may need to be ported.


PR by @klonos #191

@klonos
Copy link
Member Author

klonos commented Jul 26, 2019

...should things live under /commands/core/views.drush.inc @serundeputy?

@klonos
Copy link
Member Author

klonos commented Jul 26, 2019

Starting a PR: #191

Untested; simply added the current version of the views.druch.inc file from https://git.drupalcode.org/project/views/blob/7.x-3.x/drush/views.drush.inc, with the following changes:

  • changed instances of variable_get()/variable_set() with state_get()/state_set()

@serundeputy
Copy link
Member

serundeputy commented Jul 26, 2019

I'd probably put it in a new /commands/views directory (possibly breakout commands into there own files, but I'd have to look at the scope of the commands).

Having said that looks like there is much work to be done and testing in the command implementations.

I'm not sure that variable_*et --> state_*et is the right way to go ... usually things that were variables in Drupal are config in Backdrop, but I'd have to do a deep dive into the code here.

In general it is good to have this issue to get the ball rolling on these views commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants