Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rdflib version #439

Open
RinkeHoekstra opened this issue Feb 2, 2023 · 3 comments
Open

Bump rdflib version #439

RinkeHoekstra opened this issue Feb 2, 2023 · 3 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects

Comments

@RinkeHoekstra
Copy link

The graph-notebook package currently has a strict dependence on rdflib version 5.0.0, while that package is already at v6.2.0 at the time of writing.

rdflib==5.0.0

Version 6 is fully Python 3, and includes several optimizations (see https://rdflib.readthedocs.io/en/stable/upgrade5to6.html), and adds JSON-LD support:

6.0.0 fully adopts Python 3 practices and drops Python 2 support so it is neater, faster and generally more modern than 5.0.0. It also tidies up the Graph API (removing duplicate functions) so it does include a few breaking changes. Additionally, there is a long list of PRs merged into 6.0.0 adding a number of small fixes and features which are listed below.

@michaelnchin
Copy link
Member

Thanks for the suggestion @RinkeHoekstra !

The rdflib version pin was originally added as, the time of its release, rdflib 6.x contained breaking changes affecting %%sparql query functionality. I can't recall the exact issue, but this incompatibility may also have been specific to use with older Neptune endpoints (<1.0.5.0). I just tested graph-notebook==3.7.1 with rdflib==6.2.0 against a Neptune endpoint with engine version 1.2.0.0, and didn't seem to have any problems running basic %%sparql queries.

This does seem like a worthwhile upgrade considering the major improvements implemented in rdflib>=6.0.0; we will take a look into implementing this.

@michaelnchin michaelnchin added this to New issues/Needs triage or review in Planning via automation Feb 2, 2023
@joywa joywa moved this from New issues/Needs triage or review to Medium priority in Planning Feb 8, 2023
@joywa joywa added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 8, 2023
@pwin
Copy link

pwin commented Jan 15, 2024

This has been an open issue for almost a year now, and it seems like a simple change - see @michaelnchin comment above - yet it prevents using e.g. https://pypi.org/project/onto-tool/ or https://pypi.org/project/pyshacl/ with the notebook. Suggesting that the priority is raised

@vladistan
Copy link

vladistan commented Apr 19, 2024

Yes, having an outdated version of rdflib prevents using https://github.com/linkml/linkml. I strongly for bumping priority of this.

@michaelnchin michaelnchin moved this from Medium priority to In progress in Planning May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Planning
In progress
Development

No branches or pull requests

5 participants