Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dms: CfnDataProviderProps is missing the 'Settings' field of AWS::DMS::DataProvider. #30224

Open
stowns opened this issue May 15, 2024 · 1 comment
Labels
@aws-cdk/aws-dms Related to AWS Database Migration Service (AWS DMS) bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@stowns
Copy link
Contributor

stowns commented May 15, 2024

Describe the bug

CfnDataProviderProps is missing the 'Settings' field of AWS::DMS::DataProvider.

Expected Behavior

I would expect CfnDataProviderProps to include a settings property for configuring database properties ie)

"Settings": {
    "DocDbSettings": {
        "ServerName": "my-server-name",
        "Port": 27017,
        "DatabaseName": "docdb",
        "SslMode": "require"
    }
}

Current Behavior

There is no settings property of the CfnDataProviderProps construct

Reproduction Steps

new CfnDataProvider(this, 'my-data-provider', {
  // try to add 'settings'
})

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.141.0

Framework Version

No response

Node.js Version

18.18.0

OS

MacOS 14.4.1

Language

TypeScript

Language Version

No response

Other information

No response

@stowns stowns added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-dms Related to AWS Database Migration Service (AWS DMS) label May 15, 2024
@ashishdhingra ashishdhingra self-assigned this May 15, 2024
@ashishdhingra
Copy link
Contributor

ashishdhingra commented May 15, 2024

Reproducible.

The CFN Schema at https://github.com/cdklabs/awscdk-service-spec/commits/main/sources/CloudFormationSchema/us-east-1/aws-dms-dataprovider.json appears to be have Settings as one of the properties for AWS::DMS::DataProvider. This is in sync with https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json.

Needs review with the team.

EDIT: Looks like it was removed as part of PR cdklabs/awscdk-service-spec#1050.

PR #30182 should add Settings as property for AWS::DMS::DataProvider, once merged.

@ashishdhingra ashishdhingra added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels May 15, 2024
@ashishdhingra ashishdhingra changed the title (module name): (short issue description) dms: CfnDataProviderProps is missing the 'Settings' field of AWS::DMS::DataProvider. May 15, 2024
@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed needs-review labels May 15, 2024
@ashishdhingra ashishdhingra added the pr/work-in-progress This PR is a draft and needs further work. label May 20, 2024
@ashishdhingra ashishdhingra added p1 and removed p2 labels May 28, 2024
@ashishdhingra ashishdhingra removed their assignment May 28, 2024
@ashishdhingra ashishdhingra removed the pr/work-in-progress This PR is a draft and needs further work. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-dms Related to AWS Database Migration Service (AWS DMS) bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

No branches or pull requests

2 participants