-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): add artifactS3Encryption
property to the Canary Construct.
#30197
base: main
Are you sure you want to change the base?
Conversation
@@ -296,6 +344,31 @@ export class Canary extends cdk.Resource implements ec2.IConnectable { | |||
this._connections = new ec2.Connections({}); | |||
} | |||
|
|||
if (props.runtime.family !== RuntimeFamily.NODEJS && props.artifactS3Encryption) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Artifact encryption functionality is available only for canaries that use Synthetics runtime version syn-nodejs-puppeteer-3.3 or later.
However, versions prior to 3.3 are deprecated and can no longer be configured, which is why I implemented it this way.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #30190.
Reason for this change
To select encryption options.
Description of changes
Add
artifactS3Encryption
property to the Canary Construct.Description of how you validated changes
Add unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license