Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(appconfig-alpha): grant read Configuration #28585

Closed
2 tasks
yamatatsu opened this issue Jan 5, 2024 · 2 comments · Fixed by #30180
Closed
2 tasks

(appconfig-alpha): grant read Configuration #28585

yamatatsu opened this issue Jan 5, 2024 · 2 comments · Fixed by #30180
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@yamatatsu
Copy link
Contributor

Describe the feature

Now appconfig-alpha has no grant method. If grantReadConfig() is implemented, it will be useful.

Use Case

Using AppConfig from application codes.

Proposed Solution

environment.grantReadConfig(lambdaFunction);

Other Information

Needed policy is following:

new iam.PolicyStatement({
  actions: [
    "appconfig:GetLatestConfiguration",
    "appconfig:StartConfigurationSession",
  ],
  resources: [`${appConfigEnvironment.environmentArn}/*`],
})

see, https://docs.aws.amazon.com/appconfig/latest/userguide/about-data-plane.html

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.114.1

Environment details (OS name and version, etc.)

Mac OS, Apple silicon, Sonoma 14.2.1
@yamatatsu yamatatsu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2024
@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Jan 5, 2024
@pahud
Copy link
Contributor

pahud commented Jan 5, 2024

Absolutely! Thank you @yamatatsu !

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2024
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
@mazyu36 mazyu36 mentioned this issue May 13, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #30180 May 29, 2024
mergify bot pushed a commit that referenced this issue May 29, 2024
@mazyu36
feat(appconfig): add grantReadConfig method to Environment Construct (#…
c8f2646 
…30180)

### Issue # (if applicable)

Closes #28585

### Reason for this change
To simplify policy configuration for AppConfig Environments.



### Description of changes
add grantReadConfig method to Environment Construct



### Description of how you validated changes
Add unit test and integ tests


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

atanaspam pushed a commit to atanaspam/aws-cdk that referenced this issue Jun 3, 2024
@mazyu36 @atanaspam
feat(appconfig): add grantReadConfig method to Environment Construct (a…
f98bbd1 
…ws#30180)

### Issue # (if applicable)

Closes aws#28585

### Reason for this change
To simplify policy configuration for AppConfig Environments.



### Description of changes
add grantReadConfig method to Environment Construct



### Description of how you validated changes
Add unit test and integ tests


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(appconfig): add grantReadConfig method to Environment Construct mazyu36/aws-cdk
2 participants
@pahud @yamatatsu