-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): proactive evaluation mode #30174
Open
badmintoncryer
wants to merge
11
commits into
aws:main
Choose a base branch
from
badmintoncryer:30172-proactiveEvaluation
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(config): proactive evaluation mode #30174
badmintoncryer
wants to merge
11
commits into
aws:main
from
badmintoncryer:30172-proactiveEvaluation
+944
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature-request
A feature should be added or improved.
p2
star-contributor
[Pilot] contributed between 25-49 PRs to the CDK
labels
May 13, 2024
aws-cdk-automation
added
the
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
label
May 13, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature-request
A feature should be added or improved.
p2
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
star-contributor
[Pilot] contributed between 25-49 PRs to the CDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #30172.
Reason for this change
AWS Config supports for proactive evaluation mode but L2 construct cannot configure it.
Description of changes
EvaluationMode
classevaluationModes
prop toRuleProps
Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license