Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敡 Add a setting to point to a MakeMKV profile file #1111

Open
2 tasks done
SylvainMT opened this issue Apr 13, 2024 · 0 comments
Open
2 tasks done

馃敡 Add a setting to point to a MakeMKV profile file #1111

SylvainMT opened this issue Apr 13, 2024 · 0 comments
Labels
enhancement New feature request/PR
Milestone

Comments

@SylvainMT
Copy link
Contributor

Is this feature missing in the latest version?

  • I'm using the latest release

Is your feature request related to a problem? Please describe.

By default, MakeMKV makes some basic track selections for audio and subtitle tracks. These selections are not necessarily the best options for all users.

Reading the MakeMKV forums provided the answer in the form of a profile file, which contains a new track selection.

By Default ARM should be using a track selection for MakeMKV that is all-inclusive. It should include all audio and all subtitle tracks, regardless of language or audio quality/channels. Why, because Handbrake, the second step in the ARM process offers a far more convenient way of creating profiles using their GUI.

Describe the solution you'd like?

So the feature is two-fold.

  1. Create a custom, ARM specific MakeMKV profile and use that as the default one.
  2. Allow the user to create their own MakeMKV profile file and then upload it to ARM using the ripper settings screen in arm.

The new Option in Ripper Settings could be MAKEMKV_PROFILE_FILE which is a browse field allowing the user to upload a new file and for ARM to use that as the profile for future rips.

This can be done via makemkvcon --profile={ValueOfNewFild} when calling MakeMKV from ARM.

Describe alternatives you've considered?

I have been doing this manually by creating a new profile, uploading it to my /home/arm directory and then using the MKV_ARGS field inside arm.yaml

Anything else?

Links to the MakeMKV forums that are present in the new Wiki page that was pulled a few days ago.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@SylvainMT SylvainMT added the enhancement New feature request/PR label Apr 13, 2024
@microtechno9000 microtechno9000 added this to the 3.0 milestone Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request/PR
Projects
Status: Todo
Development

No branches or pull requests

2 participants