You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When copying completed rips to the "completed" folder, if the destination file already exists, the files are not copied but it doesn't fail the job. Because the job continues as if the copy was successful, it proceeds to delete the completed files thinking that they're just intermediate transcode files.
This can happen when ripping multi-disk series when all disks get identified as the same series, and thus end up trying to write to the same folder.
To Reproduce
Configure an OMDB API key
Rip disk 1 of a multi-disk series (I used "Vampire Knight (2008)")
Attempt to rip disk 2 of the series
Observe the second rip job succeed with no output to the completed folder
What OS are you seeing the problem on?
Other (please state in Anything else? section)
ARM Release Version or Git hash (You can find this in the arm settings page)
v2.6.67
Expected behavior?
I expected one of the following:
The destination file already existing fails the second job
A new destination filename is chosen for the second job
The second disk is identified differently than the first one, avoiding conflicts to begin with
Relevant log output
[12-11-2023 19:54:13] INFO ARM: Handbrake processing complete
[12-11-2023 19:54:13] INFO ARM: ************* Finished Transcode With HandBrake *************
[12-11-2023 19:54:13] INFO ARM: Removing raw path - /home/arm/media/completed/tv/Vampire Knight (2008)_170232371686
[12-11-2023 19:54:14] INFO ARM: Moving series A1_t00.mkv to /home/arm/media/completed/tv/Vampire Knight (2008)
[12-11-2023 19:54:14] INFO ARM: Moving '/home/arm/media/transcode/tv/Vampire Knight (2008)_170232371686/A1_t00.mkv' to /home/arm/media/completed/tv/Vampire Knight (2008)
[12-11-2023 19:54:14] INFO ARM: File: /home/arm/media/completed/tv/Vampire Knight (2008)/A1_t00.mkv already exists. Not moving.
[12-11-2023 19:54:14] INFO ARM: EMBY_REFRESH config parameter is false. Skipping emby scan.
[12-11-2023 19:54:14] INFO ARM: Removing raw path - /home/arm/media/raw/Vampire Knight_170232371686
[12-11-2023 19:54:14] INFO ARM: Removing raw path - /home/arm/media/transcode/tv/Vampire Knight (2008)_170232371686
[12-11-2023 19:54:14] INFO ARM: Removing raw path - /home/arm/media/raw/Vampire Knight_170232371686
[12-11-2023 19:54:14] INFO ARM: ************* ARM processing complete*************
Anything else?
Reproduced on the docker distribution.
Code of Conduct
I agree to follow this project's Code of Conduct
The text was updated successfully, but these errors were encountered:
Is there an existing issue for this?
I have checked the wiki
Does this issue exist in the latest version?
Describe the bug?
When copying completed rips to the "completed" folder, if the destination file already exists, the files are not copied but it doesn't fail the job. Because the job continues as if the copy was successful, it proceeds to delete the completed files thinking that they're just intermediate transcode files.
This can happen when ripping multi-disk series when all disks get identified as the same series, and thus end up trying to write to the same folder.
To Reproduce
What OS are you seeing the problem on?
Other (please state in Anything else? section)
ARM Release Version or Git hash (You can find this in the arm settings page)
v2.6.67
Expected behavior?
I expected one of the following:
Relevant log output
Anything else?
Reproduced on the docker distribution.
Code of Conduct
The text was updated successfully, but these errors were encountered: