Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does any part of our CI use pycodestyle? #16477

Open
nstarman opened this issue May 20, 2024 · 2 comments
Open

Does any part of our CI use pycodestyle? #16477

nstarman opened this issue May 20, 2024 · 2 comments

Comments

@nstarman
Copy link
Member

We have a configuration for pycodestyle, but it isn't used in our CI.
Why carry configs for tools we don't use in our CI? Can we get rid of it?

@nstarman nstarman changed the title Does anyone use pycodestyle? Does any part of our CI use pycodestyle? May 20, 2024
@neutrinoceros
Copy link
Contributor

I believe flake8 respects pycodestyle's configuration, so it would be the same question as to why we carry a .flake8 file. Last I heard, @pllim was having issues with pre-commit+ruff on windows so the argument was that keeping these configurations around helped mitigate this hurdle and and didn't hurt. It seems to me that we need to make sure the recommended tooling isn't getting in the way of anyone's workflow (at least not core devs).

Maybe the solution it fixing everyone's broken installs during the upcoming coordination meeting ? (I think I'm only half joking)

@pllim
Copy link
Member

pllim commented May 21, 2024

Still not too late to propose topic at astropy/astropy-project#349 for the unconference/hack sessions maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants