Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flynt with ruff? #14934

Closed
nstarman opened this issue Jun 8, 2023 · 2 comments · Fixed by #16421
Closed

Replace flynt with ruff? #14934

nstarman opened this issue Jun 8, 2023 · 2 comments · Fixed by #16421
Labels
dev-automation Feature Request

Comments

@nstarman
Copy link
Member

nstarman commented Jun 8, 2023 •
edited

What is the problem this feature will solve?

can we do it?
https://beta.ruff.rs/docs/rules/#flynt-fly

Describe the desired outcome

No response

Additional context

Ping @WilliamJamieson
@nstarman
Copy link
Member Author

nstarman commented Jul 3, 2023

@WilliamJamieson, does Ruff now cover our Flynt usage?

@WilliamJamieson
Copy link
Contributor

I have not been following Ruff very closely recently. Before, it did not cover fixing the printf formatting, and ignoring the cases where the printf formatting was used in logging statements. Flynt is only being used in the weekly cron and it runs extremely fast, so I don't think it is hurting anything.

If you think it covers the flynt usage then you can replace/drop it.

@eerovaher eerovaher mentioned this issue May 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-automation Feature Request
Projects
Astropy Infrastructure
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using flynt eerovaher/astropy
3 participants
@pllim @nstarman @WilliamJamieson