Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected rye lint to output 'All checks passed!' #1065

Open
my1e5 opened this issue May 9, 2024 · 1 comment
Open

Expected rye lint to output 'All checks passed!' #1065

my1e5 opened this issue May 9, 2024 · 1 comment

Comments

@my1e5
Copy link
Contributor

my1e5 commented May 9, 2024

If we look at rye fmt, its behaviour is consistent with running rye run ruff format .:

$ rye fmt
2 files left unchanged

$ rye run ruff format .
2 files left unchanged

But if I run rye lint, it doesn't print 'All checks passed!' when rye run ruff check . does.

$ rye lint

$ rye run ruff check .
All checks passed!

It can be confusing to the end-user who might expect rye lint to print 'All checks passed!'. You wonder if it actually ran properly?

Can rye lint be made consistent with rye run ruff check .?

@mitsuhiko
Copy link
Collaborator

That's because this is how ruff behaves today. I did not want to make too many changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants