Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the "share this page" button #121

Open
nfee006 opened this issue May 12, 2021 · 2 comments
Open

Implement the "share this page" button #121

nfee006 opened this issue May 12, 2021 · 2 comments

Comments

@nfee006
Copy link
Member

nfee006 commented May 12, 2021

Earlier attempts have been unsuccessful, likely due to interactions between the JS libraries used by wet-boew and by CKAN (see open-data/ckanext-canada#1191).

image

@nfee006 nfee006 added Enhancement New feature or request From Comms labels May 12, 2021
@nfee006
Copy link
Member Author

nfee006 commented May 12, 2021

See also asc-csa/AlouetteApp#128 and asc-csa/Scisat-App#137

@duboisp
Copy link

duboisp commented Jun 11, 2021

It is possible to not use the magnific popup for the share this page widget and use instead the overlay plugin.

It will only require someone to send a PR to make that change into the wet-boew share plugin here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request From Comms
Development

No branches or pull requests

2 participants