Added detailed stats for today grouped by user. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `detailedGitStats` function into two functions. - The `detailedGitStats` function has been renamed to `_detailedGitStats`. - The new `_detailedGitStats` function is almost identical to the old function, except it now doesn't output a title and it takes any number of arguments that get injected into the `git log` command (via the `$@` variable). This increases its flexibility, so that it can be used in other places without duplicating code. - The `detailedGitStats` function now outputs a title and calls the `_detailedGitStats` function with the `$_since` and `$_until` variables as parameters (these are passed to the `git log` command as described above). Added the `detailedGitStatsTodayByAuthor` function. - This function gets the stats for today grouped by author. - It uses the `_detailedGitStats` function to do this by passing in the `--since` flag that get passed to `git log`. Added the `detailedGitStatsTodayByAuthor` to the interactive menu. Added the `detailedGitStatsTodayByAuthor` to the non-interactive list of options that can be given as a command line argument. Added the `detailedGitStatsTodayByAuthor` to the list of possible arguments. Tested options 1 and 2 with this repository and output is behaving as expected. Tested options 1 and 2 with `_GIT_SINCE` and `_GIT_UNTIL` and output is behaving as expected. This should resolve #3.
|
Hi @vimist, Thanks for your contribution. I think your changes are same as this use case scenario: |
|
@arzzen, any further thoughts on this? |
|
I think this "today stats" are too simple
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
detailedGitStatsfunction into two functions.detailedGitStatsfunction has been renamed to_detailedGitStats._detailedGitStatsfunction is almost identical to theold function, except it now doesn't output a title and it takes any
number of arguments that get injected into the
git logcommand (viathe
$@variable). This increases its flexibility, so that it can beused in other places without duplicating code.
detailedGitStatsfunction now outputs a title and calls the_detailedGitStatsfunction with the$_sinceand$_untilvariables as parameters (these are passed to the
git logcommand asdescribed above).
Added the
detailedGitStatsTodayByAuthorfunction._detailedGitStatsfunction to do this by passing in the--sinceflag that get passed togit log.Added the
detailedGitStatsTodayByAuthorto the interactive menu.Added the
detailedGitStatsTodayByAuthorto the non-interactive list ofoptions that can be given as a command line argument.
Added the
detailedGitStatsTodayByAuthorto the list of possiblearguments.
Tested options 1 and 2 with this repository and output is behaving as
expected.
Tested options 1 and 2 with
_GIT_SINCEand_GIT_UNTILand output isbehaving as expected.
This should resolve #3.