Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Text Editor #38

Open
aritra-tech opened this issue Aug 16, 2023 · 15 comments
Open

Create a Text Editor #38

aritra-tech opened this issue Aug 16, 2023 · 15 comments
Labels
approved Approved by the maintainer & ready for dev enhancement New feature or request features hacktoberfest help wanted Extra attention is needed priority-high
Milestone

Comments

@aritra-tech
Copy link
Owner

Create a Text Editor in AddNoteScreen where there will be buttons for Bold, Italic, Strikethrough, etc.

@aritra-tech aritra-tech added this to the v1.3.0 milestone Aug 23, 2023
@aritra-tech aritra-tech modified the milestones: v1.3.0, v1.4.0 Sep 7, 2023
@aritra-tech aritra-tech added help wanted Extra attention is needed approved Approved by the maintainer & ready for dev hacktoberfest labels Sep 25, 2023
@githubashutoshsoni
Copy link

Can you please assign this to me?

@aritra-tech
Copy link
Owner Author

Sure @githubashutoshsoni
All the best.

@githubashutoshsoni
Copy link

githubashutoshsoni commented Oct 4, 2023

@aritra-tech we have handful of libraries for compose yet they are not very customizing. can you suggest some library that does this or we need to build our own custom compose library for rich edit text? I checked out the below it does most of the job but BaseEditText does not have onValueChange function that can return the result

compose rich editor

@aritra-tech
Copy link
Owner Author

I suggest not to use a third party library.

@githubashutoshsoni
Copy link

Okay, I've got it working. Can you please merge single tap to top to develop branch since I got this completed as well. I will update this once I you do a quick merge to develop branch so there are no conflicts.

@aritra-tech
Copy link
Owner Author

I have requested some changes in the PR that you have created please check it out. Once it's fixed I will merge it out.

@aritra-tech aritra-tech modified the milestones: v1.4.1, v1.5.1 Oct 6, 2023
@aritra-tech
Copy link
Owner Author

Hey @githubashutoshsoni any updates?

@githubashutoshsoni
Copy link

I haven't resolved the issue yet. The creation of a new note functions correctly, but editing an existing note seems to be malfunctioning. Could you please review it in this pull request? #141

  RichTextStyleRow(
                modifier = Modifier.fillMaxWidth(),
                state = basicRichTextState,
            )

            RichTextEditor(
                state = basicRichTextState,
                modifier = Modifier
                    .fillMaxSize(),
                textStyle = TextStyle(
                    fontSize = 18.sp,
                    fontFamily = FontFamily(Font(R.font.poppins_light)),
                ),
                keyboardOptions = KeyboardOptions.Default.copy(
                    capitalization = KeyboardCapitalization.Sentences,
                    keyboardType = KeyboardType.Text,
                ),

                maxLines = Int.MAX_VALUE,
                placeholder = {
                    Text(
                        stringResource(R.string.notes),
                        fontSize = 20.sp,
                        fontWeight = FontWeight.W500,
                        color = Color.Gray,
                        fontFamily = FontFamily(Font(R.font.poppins_light))
                    )
                },
            )
            description = basicRichTextState.annotatedString.text
            if (isNew) {
                characterCount = title.length + description.length
            } else {
                addEditViewModel.updateDescription(description)
            } 

@aritra-tech
Copy link
Owner Author

Hey @githubashutoshsoni can you please fix the changes that I have told you regarding the PR that you have raised.

@Ismail-AD
Copy link
Contributor

@aritra-tech i am back assign it to me and also have you uploaded any post about changes in v1.5.1 on LinkedIn

@aritra-tech
Copy link
Owner Author

Yeah sure
All the best 👋

@Ismail-AD
Copy link
Contributor

I have tried it today the thing is it will change all the text style rather the upcoming typed text and the library of RICH text compose will change the total structure of your description text field function which i don't want to do !!!!

@Ismail-AD Ismail-AD removed their assignment Oct 22, 2023
@aritra-tech
Copy link
Owner Author

Which library did you use?
This one - https://github.com/MohamedRejeb/Compose-Rich-Editor

@Ismail-AD
Copy link
Contributor

yes this one
But the library of RICH text compose will change the total structure of your description text field function which i don't want to do !!!!

@aritra-tech
Copy link
Owner Author

Okay got your point.

@aritra-tech aritra-tech modified the milestones: v1.6.1, v1.7.1 Oct 25, 2023
@aritra-tech aritra-tech modified the milestones: v1.7.1, v1.8.1 Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the maintainer & ready for dev enhancement New feature or request features hacktoberfest help wanted Extra attention is needed priority-high
Projects
Status: To do 🗒
Development

No branches or pull requests

3 participants