🐛 Bug Report: Expired targets not automatically deleted

[ayushpathak-48]

👟 Reproduction steps

Go to console

Create FCM provider for push messaging

Create a token of a device and save it into appwrite

Then re create the token and again save it to appwrite

Then send notification to the web target

Then you will get an error for the expired device token

Again after 1 day th same error occurs.

But appwrite says it should be removed after a days if it's expired

👍 Expected behavior

It should be removed

👎 Actual Behavior

It's giving same errror everyday

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

Windows

🧱 Your Environment

I am using node-appwrite to create push target and for creating push notification

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[stnguyen90]

Related thread: https://discord.com/channels/564160730845151244/1241034854922063954

[stnguyen90]

@ayushpathak-48, thanks for raising this issue! 🙏🏼 We do mark expired targets as such:

appwrite/src/Appwrite/Platform/Workers/Messaging.php

Lines 272 to 284 in fd72289

	if (($result['error'] ?? '') === 'Expired device token') {
	$target = $dbForProject->findOne('targets', [
	Query::equal('identifier', [$result['recipient']])
	]);
	if ($target instanceof Document && !$target->isEmpty()) {
	$dbForProject->updateDocument(
	'targets',
	$target->getId(),
	$target->setAttribute('expired', true)
	);
	}
	}

but it seems like the maintenance task that deletes expired targets isn't triggered per project:

appwrite/src/Appwrite/Platform/Tasks/Maintenance.php

Lines 44 to 64 in 3d8bdef

	Console::loop(function () use ($interval, $cacheRetention, $schedulesDeletionRetention, $usageStatsRetentionHourly, $dbForConsole, $queueForDeletes, $queueForCertificates) {
	$time = DateTime::now();
	Console::info("[{$time}] Notifying workers with maintenance tasks every {$interval} seconds");
	$this->foreachProject($dbForConsole, function (Document $project) use ($queueForDeletes, $usageStatsRetentionHourly) {
	$queueForDeletes->setProject($project);
	$this->notifyDeleteExecutionLogs($queueForDeletes);
	$this->notifyDeleteAbuseLogs($queueForDeletes);
	$this->notifyDeleteAuditLogs($queueForDeletes);
	$this->notifyDeleteUsageStats($usageStatsRetentionHourly, $queueForDeletes);
	$this->notifyDeleteExpiredSessions($queueForDeletes);
	});
	$this->notifyDeleteConnections($queueForDeletes);
	$this->renewCertificates($dbForConsole, $queueForCertificates);
	$this->notifyDeleteCache($cacheRetention, $queueForDeletes);
	$this->notifyDeleteSchedules($schedulesDeletionRetention, $queueForDeletes);
	$this->notifyDeleteTargets($queueForDeletes);
	}, $interval, $delay);

so the delete worker doesn't delete the expired targets per project:

appwrite/src/Appwrite/Platform/Workers/Deletes.php

Lines 292 to 304 in fd72289

	private function deleteExpiredTargets(Document $project, callable $getProjectDB): void
	{
	$this->deleteByGroup(
	'targets',
	[
	Query::equal('expired', [true])
	],
	$getProjectDB($project),
	function (Document $target) use ($getProjectDB, $project) {
	$this->deleteTargetSubscribers($project, $getProjectDB, $target);
	}
	);
	}

[ItzNotABug]

@stnguyen90 is this issue open for assignment?

[stnguyen90]

@ItzNotABug, sure, ya. Assigned!