Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to pdf and Download as image actions not translated in french #28431

Open
3 tasks done
martin-raymond opened this issue May 10, 2024 · 2 comments
Open
3 tasks done

Comments

@martin-raymond
Copy link
Contributor

Bug description

On top of the dashboard, in the drop down menu, in french, the action to 'Export to pdf' and 'Download as image' are not translated.
image

How to reproduce the bug

  1. Have your superset current languages in french
  2. Open the drop down menu top right on your dashboard
  3. Expand the download section

Screenshots/recordings

No response

Superset version

3.1.3

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
Copy link

dosubot bot commented May 10, 2024

To address the issue where 'Export to PDF' and 'Download as Image' options are not translated into French in Superset version 3.1.3, you should first verify if the translation strings for these actions exist in the French localization file (superset/translations/fr/LC_MESSAGES/messages.po). If they're missing, you can add them as follows:

msgid "Export to PDF"
msgstr "Exporter en PDF"

msgid "Download as Image"
msgstr "Télécharger comme image"

After adding these strings, compile the translation files with:

flask fab babel-compile --target superset/translations

Then, restart Superset to apply the changes. This process ensures that Superset uses the updated translations, making the 'Export to PDF' and 'Download as Image' options appear in French.

For more detailed guidance on managing translations in Superset, including how dynamic content is translated, refer to the Superset repository and specifically the French localization file here. This file is crucial for the localization process, enabling Superset to display UI elements in French based on the user's locale settings.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

@rusackas
Copy link
Member

I'll leave this open for a bit, but we don't consider missing translations as bugs. If we did, we'd have a LOT of bugs. We encourage you to open PRs to add/fix as many translations as you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants