Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): invalid drop item on a tab #28507

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(dashboard): invalid drop item on a tab #28507

merged 2 commits into from
May 15, 2024

Conversation

justinpark
Copy link
Member

SUMMARY

The Tab component was inadvertently appending the item into its sibling.
This commit fixes the #28417 by adding correct dropToChild logic for Tab component, ensuring that items are placed where they should be.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
before--tab-drop.mov
  • After
after--tab-drop.mov

TESTING INSTRUCTIONS

  • Drop a chart component into a Tab
  • The drop component should be place underneath the tab

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend dashboard:tab Related to the usage of tabs in the Dashboard labels May 14, 2024
@justinpark justinpark linked an issue May 14, 2024 that may be closed by this pull request
Dragging a chart onto a top-level tab (not an in-dash tab set) makes the chart a new (broken) tab #28417
Closed
3 tasks
@michael-s-molina michael-s-molina merged commit 65e0d54 into apache:master May 15, 2024
31 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label May 15, 2024
michael-s-molina pushed a commit that referenced this pull request May 15, 2024
@justinpark @michael-s-molina
fix(dashboard): invalid drop item on a tab (#28507)
d135976 
(cherry picked from commit 65e0d54)
@rusackas
Copy link
Member

THANK YOU! ❤️

jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@justinpark @jzhao62
fix(dashboard): invalid drop item on a tab (apache#28507)
bacc812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend dashboard:tab Related to the usage of tabs in the Dashboard size/L v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dragging a chart onto a top-level tab (not an in-dash tab set) makes the chart a new (broken) tab
3 participants
@justinpark @rusackas @michael-s-molina