-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][misc] PIP-351: Add options to Pulsar-Test client to support KeyStore based TLS #22692
base: master
Are you sure you want to change the base?
[improve][misc] PIP-351: Add options to Pulsar-Test client to support KeyStore based TLS #22692
Conversation
50c9886
to
d0d5384
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
BTW, this PR requires a PIP.
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceBaseArguments.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerfClientUtilsTest.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerformanceBaseArgumentsTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert return String.format(Locale.US, format, get_FloatValue(size));
.
47a92f6
to
09ef3f9
Compare
0a6839e
to
9ddc238
Compare
9ddc238
to
8d34bf0
Compare
PIP has been accepted and merged. https://lists.apache.org/thread/61l7bdhkjy0vy61934shmh2cphb6pp06 Good work @shasank112001 |
…erformanceBaseArguments.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceBaseArgumentsTest.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
406e8fa
to
8433bc8
Compare
Fixes #22678
Main Issue: #22678
PIP: #22694
Motivation
If you want to create a TestClient which uses AuthenticationKeyStoreTls as its authPlugin, Pulsar Test Admin/Client utilized in Pulsar-perf is unable to setup a vaild SSL context due to the requirement of the property "useKeyStoreTls" to be "true" for using keystores properly.
Moreover, utilizing the property "useKeyStoreTls" requires the use of trust-stores and not trust certificates, therefore requiring additional trustStoreType, trustStorePath and trustStorePass as parameters to be available, to utilize PulsarPerf.
Modifications
The following changes have been made:
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: PR