Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2404: Support for multi-variable join keys #2405

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

GH-2404: Support for multi-variable join keys #2405

wants to merge 2 commits into from

Conversation

Aklakan
Copy link
Contributor

@Aklakan Aklakan commented Apr 8, 2024 •
edited

GitHub issue resolved #2404

Pull request Description: This PR proposes introduction of the class MultiHashProbeTable which creates HashProbleTable indexes on demand based on the lookup requests.

I still need to test the performance with @LorenzBuehmann 's examples from the mail thread.

  • Tests are included.
  • Benchmarks are included.
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.

See the Apache Jena "Contributing" guide.

@Aklakan Aklakan marked this pull request as draft April 8, 2024 20:43
@Aklakan Aklakan force-pushed the join-fix-2024-04-08 branch 11 times, most recently from 80ad797 to 74d320d Compare April 11, 2024 06:50
@arne-bdt
Copy link

I took a quick look at the code and found a small thing that has become important to me:
In Apache Jena, the default implementation of Iterator#forEachReamaining is overridden in numerous places to achieve better performance than would be possible with #hasNext and #next.
(This was part of my contribution and the performance optimisations that came with the GrapMem2* graphs).
Could you please favour Iterator#forEachReamaining if you want to process all elements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for multi-variable join keys
2 participants
@Aklakan @arne-bdt