-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(6509): improve the test case coverage of saga module to 70% #6519
base: 2.x
Are you sure you want to change the base?
Conversation
@xjlgod You can submit your PR in stages. |
I am trying to invoke codecov action to see my test case coverage by add new commit. But I find the error is
It seems that the quota limit has been reached. |
… into feature/2.x-saga-test # Conflicts: # saga/seata-saga-spring/src/test/java/org/apache/seata/saga/engine/tm/DefaultSagaTransactionalTemplateTest.java # saga/seata-saga-spring/src/test/java/org/apache/seata/saga/engine/tm/MockGlobalTransaction.java
import java.util.Map; | ||
|
||
/** | ||
* @author jingliu_xiong@foxmail.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete the author infomation,as well as below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted it.
723a505
to
77cd034
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6519 +/- ##
============================================
+ Coverage 50.02% 52.39% +2.37%
- Complexity 5224 5447 +223
============================================
Files 950 950
Lines 33447 33443 -4
Branches 4047 4048 +1
============================================
+ Hits 16732 17523 +791
+ Misses 15104 14153 -951
- Partials 1611 1767 +156 |
Ⅰ. Describe what this PR did
fix #6509
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews