Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to filter DAGs in DAGs View by tags using "AND" instead of default behavior "OR" #38147

Open
2 tasks done
understructure opened this issue Mar 14, 2024 · 5 comments · May be fixed by #39564
Open
2 tasks done

Add ability to filter DAGs in DAGs View by tags using "AND" instead of default behavior "OR" #38147

understructure opened this issue Mar 14, 2024 · 5 comments · May be fixed by #39564
Assignees
@lotrias17
Labels
area:webserver Webserver related Issues good first issue kind:feature Feature Requests

Comments

@understructure
Copy link

understructure commented Mar 14, 2024 •
edited

Description

In the DAGs View, we can enter tags in the "Filter DAGs by tag" box by entering one or more tags. However, this results in an OR-type behavior, where the results show every DAG with any of the entered tags.

With this feature enabled, the list of DAGs returned would be a list only of those DAGs containing ALL of the user-entered tags, rather than a list of DAGs containing ANY of the user-entered tags.

Use case/motivation

This feature could be as simple as adding a checkbox next to the "Filter DAGs by tag" box (marked "use AND" or similar). This will be a great help to filter DAGs when tagging is used extensively and there are hundreds of DAGs on an instance. For instance, we're migrating legacy ELT procedures that use legacy systems. We're tagging these DAGs with all the legacy systems they use. If we could zero in on which DAGs are using legacy system A and legacy system B, it would help us to understand the relationships between those systems, and what needs to be done to no longer rely on either.

Related issues

None I'm aware of.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@understructure understructure added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Mar 14, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Mar 14, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@RNHTTR RNHTTR added area:webserver Webserver related Issues and removed needs-triage label for new issues that we didn't triage yet labels Apr 5, 2024
@RNHTTR
Copy link
Collaborator

RNHTTR commented Apr 5, 2024

@understructure would you like me to assign this task to you?

@lotrias17
Copy link
Contributor

Hello, could a colleague (@TiDeane) and I be assigned to this issue? We are working for a university project and would be grateful to implement this feature. Thank you in advance.

@understructure
Copy link
Author

@RNHTTR I'd love to but unfortunately this is a really inopportune time for me :(

@RNHTTR
Copy link
Collaborator

RNHTTR commented Apr 19, 2024

@RNHTTR I'd love to but unfortunately this is a really inopportune time for me :(

No problem! Come back to the project when you have some more time!

Hello, could a colleague (@TiDeane) and I be assigned to this issue? We are working for a university project and would be grateful to implement this feature. Thank you in advance.

Done!

TiDeane added a commit to TiDeane/airflow that referenced this issue May 6, 2024
@TiDeane @lotrias17
apache#38147: Implement AND logic checkbox for filtering DAGs
e67fd72 
Co-authored-by: Francisco Fonseca <franciscodiasfonseca@tecnico.ulisboa.pt>
TiDeane added a commit to TiDeane/airflow that referenced this issue May 11, 2024
@TiDeane @lotrias17
apache#38147: Implement AND logic checkbox for filtering DAGs
22ca7bf 
Co-authored-by: Francisco Fonseca <franciscodiasfonseca@tecnico.ulisboa.pt>
@TiDeane TiDeane linked a pull request May 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lotrias17 lotrias17

Labels
area:webserver Webserver related Issues good first issue kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement AND logic checkbox for filtering DAGs TiDeane/airflow
4 participants
@understructure @RNHTTR @lotrias17 @jscheffl