-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Passphrase prompt should not be shown for keys that have none #2836
Comments
The underlying PGP library accepts the passphrase as part of a separate |
I've pushed a change that inspects the encrypted message and skips asking for a passphrase if it's not needed, please test out the new snapshot build once it's available and let me know how it goes. |
It's not quite working. It avoids asking me for a passphrase and reaches the password display screen, but the password is never displayed. Note: if I enable the "passphrase cache", then it successfully decrypts and displays the password. This is a perfectly fine state of affairs for me personally, because it means even with the biometric auth disabled due to #2802, then there is still a biometric layer before the password comes up. Attached is a logcat from trying to decrypt a password with the passphrase cache disabled: |
Thanks for checking it out, I'll give it another go sometime today. |
Finally managed to find enough time and motivation to take another look at this, once #3069 is merged this should be resolved. |
Describe the bug
When I go to decrypt a password, Password Store asks me for a password. It's not clear, but I'm assuming it wants the passphrase for my PGP key, but there isn't one.
I can enter anything, or nothing, and click OK and it still decrypts the password.
Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
Just decrypt the password.
Screenshots
No response
Device information
Additional context
No response
The text was updated successfully, but these errors were encountered: