Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support force-subkey syntax in .gpg-id #2751

Open
l3ibi opened this issue Nov 1, 2023 · 2 comments
Open

[FEATURE] Support force-subkey syntax in .gpg-id #2751

l3ibi opened this issue Nov 1, 2023 · 2 comments
Labels
A-PGPainless Area: PGPainless-backed PGP C-feature Category: This is a feature request E-medium Effort: This requires a fair amount of work P-low Priority: low
Milestone

Comments

@l3ibi
Copy link

l3ibi commented Nov 1, 2023

Is your feature request related to a problem? Please describe.

Hello,
To use password store on different devices I use multiple subkeys for one pubkey.

So, on password-store I use the ! character to force the subkey ID like : https://lists.zx2c4.com/pipermail/password-store/2017-February/002757.html

The application send me this message, when I want to create a new password on android.

Found .gpg-id, but it contains an invalid key ID, fingerprint or user ID.

Describe the solution you'd like

Not send en error when the .gpg-id use ! to force the using subkey.

Describe alternatives you've considered

Ignore ! before \n

Additional context

No response

@l3ibi l3ibi added C-feature Category: This is a feature request S-awaiting-triage Status: New issues that have not been assessed yet labels Nov 1, 2023
@msfjarvis msfjarvis changed the title [FEATURE] Use subkey on .gpg-id [FEATURE] Support force-subkey syntax in .gpg-id Nov 1, 2023
@msfjarvis msfjarvis added E-medium Effort: This requires a fair amount of work P-low Priority: low A-PGPainless Area: PGPainless-backed PGP and removed S-awaiting-triage Status: New issues that have not been assessed yet labels Nov 1, 2023
@msfjarvis msfjarvis added this to the v2.0.0 milestone Nov 1, 2023
@l3ibi
Copy link
Author

l3ibi commented Nov 1, 2023

Duplicate #1360

@l3ibi l3ibi closed this as completed Nov 1, 2023
@msfjarvis
Copy link
Member

This cannot be fixed in OpenKeychain since it does not have support for specifying subkeys when decrypting (which is part of why the old issue was closed), but it should be possible to resolve for the new PGPainless backend.

Implementation notes

The force syntax is essentially {{ valid key id }}!, with the exclamation mark indicating that the PGP implementation should use the key as-is and not attempt to find the primary key for the specified key. The .gpg-id parser currently only allows a key id and no suffixes or prefixes, and needs to be loosened up a bit to allow for the optional exclamation mark.

I'll have to check with the PGPainless maintainers to see if there's an API for this and if not can it be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-PGPainless Area: PGPainless-backed PGP C-feature Category: This is a feature request E-medium Effort: This requires a fair amount of work P-low Priority: low
Projects
Status: 📖 Has instructions
Development

No branches or pull requests

2 participants