{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":2416064,"defaultBranch":"main","name":"whitehall","ownerLogin":"alphagov","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-09-19T15:10:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/596977?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717166166.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"0399fb07cc0480968bcd40b5f66ecef212fa94a3","ref":"refs/heads/fix-better-errors-in-docker","pushedAt":"2024-05-31T14:36:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pezholio","name":"Stuart Harrison","path":"/pezholio","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109774?s=80&v=4"},"commit":{"message":"Allow Better Errors to work with Docker\n\nI noticed that, in some circumstances, error traces were showing\nin plaintext when using Whitehall in Docker. After some research\nI found [this issue][1], the solution for which allows the host\nmachine, Docker and Better Errors to play together nicely!\n\n[1]: https://github.com/BetterErrors/better_errors/issues/270","shortMessageHtmlLink":"Allow Better Errors to work with Docker"}},{"before":"6c349028daa55e500dfd3b9873f81de8200ebbca","after":"bbdc32b156042bad1024bc77cd399b60b75f29ec","ref":"refs/heads/1171-republishing-ui-public-documents-attachments","pushedAt":"2024-05-31T14:11:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Order tests alphabetically by method","shortMessageHtmlLink":"Order tests alphabetically by method"}},{"before":"f96533d79a86b8574caba2183db81107c56cffa7","after":"fcc7bcb5895970992a95a4d50c7fc196a4381f57","ref":"refs/heads/1170-republishing-ui-public-documents-html-attachments","pushedAt":"2024-05-31T14:10:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Add UI for republishing docs w/ public ed w/ HTML\n\nAdd UI for republishing all documents with publicly-visible editions\nwith HTML attachments","shortMessageHtmlLink":"Add UI for republishing docs w/ public ed w/ HTML"}},{"before":null,"after":"6c349028daa55e500dfd3b9873f81de8200ebbca","ref":"refs/heads/1171-republishing-ui-public-documents-attachments","pushedAt":"2024-05-31T14:05:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Order tests alphabetically by method","shortMessageHtmlLink":"Order tests alphabetically by method"}},{"before":null,"after":"f96533d79a86b8574caba2183db81107c56cffa7","ref":"refs/heads/1170-republishing-ui-public-documents-html-attachments","pushedAt":"2024-05-31T13:39:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Add UI for republishing docs w/ public ed w/ HTML\n\nAdd UI for republishing all documents with publicly-visible editions\nwith HTML attachments","shortMessageHtmlLink":"Add UI for republishing docs w/ public ed w/ HTML"}},{"before":"ba968aaccb3af8989f1751fe585d08e23e0152f2","after":"654c2682c46c163b78c4e5c8200e82877990eb81","ref":"refs/heads/improve-bulk-republisher-performance","pushedAt":"2024-05-31T13:29:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Speed and DRY up bulk republisher\n\nThe bulk republisher was using `find_each` in a couple of places (based\non the corresponding Rake tasks), which can reduce memory consumption\nversus methods like `all` (per the [find_each docs][find_each-docs]).\nHowever, since we only need to get the document IDs (in order to pass\nthem to the republishing worker), using `pluck` to get an array of IDs\nin the initial query appears to be more efficient than iterating on an\nActive Record collection even with `find_each`\n\nI wrote a simple benchmark to work out which iteration method was\nquicker. The benchmark simply gets the document ID using each method,\nsince the logic concerning what we do with the ID will be unchanged. I\nran this test in the integration environment, which had 435358 documents\nat the time of the test\n\n```rb\nBenchmark.bmbm do |x|\n x.report(\"all\") { Document.all.each { |id| id } }\n x.report(\"find_each\") { Document.find_each { |id| id } }\n x.report(\"pluck\") { Document.pluck(:id).each { |id| id } }\nend\n```\n\nThe results:\n\n```\nRehearsal ---------------------------------------------\nall 3.885446 0.275336 4.160782 ( 4.459146)\nfind_each 2.994770 0.169453 3.164223 ( 3.881194)\npluck 0.264720 0.000000 0.264720 ( 0.353677)\n------------------------------------ total: 7.589725sec\n\n user system total real\nall 2.837523 0.183815 3.021338 ( 3.463605)\nfind_each 2.766133 0.129885 2.896018 ( 3.585942)\npluck 0.186966 0.020088 0.207054 ( 0.288226)\n```\n\nThis will speed up the queueing of bulk republishing tasks via the UI,\nin turn reducing the time between clicking \"Confirm republishing\" and\nseeing the confirmation on the next page\n\nSince we're now always iterating over an array of document IDs, the bulk\nrepublishing methods can be DRYed up using a private method\n\n[find_each-docs]: https://apidock.com/rails/ActiveRecord/Batches/find_each","shortMessageHtmlLink":"Speed and DRY up bulk republisher"}},{"before":null,"after":"ba968aaccb3af8989f1751fe585d08e23e0152f2","ref":"refs/heads/improve-bulk-republisher-performance","pushedAt":"2024-05-31T13:02:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Speed and DRY up bulk republisher\n\nThe bulk republisher was using `find_each` in a couple of places (based\non the corresponding Rake tasks), which can reduce memory consumption\nversus methods like `all` (per the [find_each docs][find_each-docs]).\nHowever, since we only need to get the document IDs (in order to pass\nthem to the republishing worker), using `pluck` to get an array of IDs\nin the initial query appears to be more efficient than iterating on an\nActive Record collection even with `find_each`\n\nI wrote a simple benchmark to work out which iteration method was\nquicker. The benchmark simply gets the document ID using each method,\nsince the logic concerning what we do with the ID will be unchanged. I\nran this test in the integration environment, which had 435358 documents\nat the time of the test\n\n```rb\nBenchmark.bmbm do |x|\n x.report(\"all\") { Document.all.each { |id| id } }\n x.report(\"find_each\") { Document.find_each { |id| id } }\n x.report(\"pluck\") { Document.all.pluck(:id).each { |id| id } }\nend\n```\n\nThe results:\n\n```\nRehearsal ---------------------------------------------\nall 4.123893 0.174160 4.298053 ( 4.686924)\nfind_each 2.978790 0.166124 3.144914 ( 3.783157)\npluck 0.236435 0.001187 0.237622 ( 0.316680)\n------------------------------------ total: 7.680589sec\n\n user system total real\nall 2.877163 0.144343 3.021506 ( 3.458602)\nfind_each 2.802409 0.121306 2.923715 ( 3.577661)\npluck 0.205850 0.000000 0.205850 ( 0.287963)\n```\n\nThis will speed up the queueing of bulk republishing tasks via the UI,\nin turn reducing the time between clicking \"Confirm republishing\" and\nseeing the confirmation on the next page\n\nSince we're now always iterating over an array of document IDs, the bulk\nrepublishing methods can be DRYed up using a private method\n\n[find_each-docs]: https://apidock.com/rails/ActiveRecord/Batches/find_each","shortMessageHtmlLink":"Speed and DRY up bulk republisher"}},{"before":"2d5fd5d5a0fe464b9968caceb595721ce515e8f0","after":null,"ref":"refs/heads/phone-number-deletion-two","pushedAt":"2024-05-31T08:36:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"}},{"before":"cd622b037fc79de6448e6d5805eb48c298deff88","after":"23902fa3f5e2c3b26c783713bdd08ce74f348b1d","ref":"refs/heads/main","pushedAt":"2024-05-31T08:36:53.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"},"commit":{"message":"Merge pull request #9094 from alphagov/phone-number-deletion-two\n\n'Refactor' of Delete blank contacts function","shortMessageHtmlLink":"Merge pull request #9094 from alphagov/phone-number-deletion-two"}},{"before":"11521e8d81a20cba0079a2b64b3c9de315704ceb","after":"6432c5d9d930a8cf33c6b56485497c3075e63b46","ref":"refs/heads/1168-republish-all-documents-with-pre-publication-editions-with-html-attachments-ui","pushedAt":"2024-05-30T19:18:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Add UI for republishing docs w/ pre-pub ed w/ HTML\n\nAdd UI for republishing all documents with pre-publication editions with\nHTML attachments","shortMessageHtmlLink":"Add UI for republishing docs w/ pre-pub ed w/ HTML"}},{"before":"304f275796214c957708c3169dc650f45516c2c3","after":"09ff5ee43c601025c55f0c14d4e4fceca6194880","ref":"refs/heads/tidy-up-bulk-republishing","pushedAt":"2024-05-30T19:18:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Break down `BulkRepublisher` test\n\nBreaking these assertions into multiple tests makes it a little easier\nto parse","shortMessageHtmlLink":"Break down BulkRepublisher test"}},{"before":null,"after":"304f275796214c957708c3169dc650f45516c2c3","ref":"refs/heads/tidy-up-bulk-republishing","pushedAt":"2024-05-30T19:14:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Break down `BulkRepublisher` test\n\nBreaking these assertions into multiple tests makes it a little easier\nto parse","shortMessageHtmlLink":"Break down BulkRepublisher test"}},{"before":"0b54b636d251f90d112dc63fc9aae48ef228c4e7","after":"11521e8d81a20cba0079a2b64b3c9de315704ceb","ref":"refs/heads/1168-republish-all-documents-with-pre-publication-editions-with-html-attachments-ui","pushedAt":"2024-05-30T19:05:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Add UI for republishing docs w/ pre-pub ed w/ HTML\n\nAdd UI for republishing all documents with pre-publication editions with\nHTML attachments","shortMessageHtmlLink":"Add UI for republishing docs w/ pre-pub ed w/ HTML"}},{"before":"d81003f5a4428d4622dd4a2a9db83dc349913d1c","after":"0b54b636d251f90d112dc63fc9aae48ef228c4e7","ref":"refs/heads/1168-republish-all-documents-with-pre-publication-editions-with-html-attachments-ui","pushedAt":"2024-05-30T18:59:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Add UI for republishing docs w/ pre-pub ed w/ HTML\n\nAdd UI for republishing all documents with pre-publication editions with\nHTML attachments","shortMessageHtmlLink":"Add UI for republishing docs w/ pre-pub ed w/ HTML"}},{"before":"76af1403e2607798405208d97e506e83a976e045","after":"d81003f5a4428d4622dd4a2a9db83dc349913d1c","ref":"refs/heads/1168-republish-all-documents-with-pre-publication-editions-with-html-attachments-ui","pushedAt":"2024-05-30T18:29:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP Add UI for republishing docs w/ pre-pub ed w/ HTML\n\nAdd UI for republishing all documents with pre-publication editions with\nHTML attachments","shortMessageHtmlLink":"WIP Add UI for republishing docs w/ pre-pub ed w/ HTML"}},{"before":null,"after":"76af1403e2607798405208d97e506e83a976e045","ref":"refs/heads/1168-republish-all-documents-with-pre-publication-editions-with-html-attachments-ui","pushedAt":"2024-05-30T18:11:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP Add UI for republishing docs w/ pre-pub ed w/ HTML\n\nAdd UI for republishing all documents with pre-publication editions with\nHTML attachments","shortMessageHtmlLink":"WIP Add UI for republishing docs w/ pre-pub ed w/ HTML"}},{"before":"3393ad091f3c86a66bddd357f27b40004a8090b1","after":"2d5fd5d5a0fe464b9968caceb595721ce515e8f0","ref":"refs/heads/phone-number-deletion-two","pushedAt":"2024-05-30T16:07:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"},"commit":{"message":"Adding review action from https://github.com/alphagov/whitehall/pull/9084\nthat I missed.","shortMessageHtmlLink":"Adding review action from #9084"}},{"before":"efcdfcb6acaab8120967e2bf6ea34051b78d3bc0","after":"3393ad091f3c86a66bddd357f27b40004a8090b1","ref":"refs/heads/phone-number-deletion-two","pushedAt":"2024-05-30T15:48:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"},"commit":{"message":"Adding review action from https://github.com/alphagov/whitehall/pull/9084\nthat I missed.","shortMessageHtmlLink":"Adding review action from #9084"}},{"before":null,"after":"627aa89ea09fa082b71c77c3c37e9e708ed7fa8f","ref":"refs/heads/make_admin_links_visable","pushedAt":"2024-05-30T15:25:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"GDSNewt","name":"Alex Newton","path":"/GDSNewt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/41922771?s=80&v=4"},"commit":{"message":"Add support for adding admin links to preview pages","shortMessageHtmlLink":"Add support for adding admin links to preview pages"}},{"before":null,"after":"efcdfcb6acaab8120967e2bf6ea34051b78d3bc0","ref":"refs/heads/phone-number-deletion-two","pushedAt":"2024-05-30T14:57:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"},"commit":{"message":"Adding review action from https://github.com/alphagov/whitehall/pull/9084\nthat I missed.","shortMessageHtmlLink":"Adding review action from #9084"}},{"before":"deec89061ab5ea6741c7a185fa29e91ae1b15fcb","after":null,"ref":"refs/heads/revert-9084-phone-number-deletion","pushedAt":"2024-05-30T14:53:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"}},{"before":null,"after":"deec89061ab5ea6741c7a185fa29e91ae1b15fcb","ref":"refs/heads/revert-9084-phone-number-deletion","pushedAt":"2024-05-30T14:50:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"},"commit":{"message":"Revert \"Delete blank contacts\"","shortMessageHtmlLink":"Revert \"Delete blank contacts\""}},{"before":"94285406d9e076860b6748b0351532d4dffc3e55","after":null,"ref":"refs/heads/phone-number-deletion","pushedAt":"2024-05-30T14:08:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"}},{"before":"edd2a98d8f31607a191e6f74877e19087deaac97","after":"cd622b037fc79de6448e6d5805eb48c298deff88","ref":"refs/heads/main","pushedAt":"2024-05-30T14:08:47.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"callumknights","name":null,"path":"/callumknights","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547183?s=80&v=4"},"commit":{"message":"Merge pull request #9084 from alphagov/phone-number-deletion\n\nDelete blank contacts","shortMessageHtmlLink":"Merge pull request #9084 from alphagov/phone-number-deletion"}},{"before":"be120e3f69f138002eb4787cec973ebc7464530a","after":null,"ref":"refs/heads/1169-republish-all-documents-with-pre-publication-editions-ui","pushedAt":"2024-05-30T14:01:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"}},{"before":"85f994c891a028db711f44e4ed2647b71d209e7e","after":"edd2a98d8f31607a191e6f74877e19087deaac97","ref":"refs/heads/main","pushedAt":"2024-05-30T14:01:30.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Merge pull request #9092 from alphagov/1169-republish-all-documents-with-pre-publication-editions-ui\n\nAdd UI for republishing all documents with pre-publication editions","shortMessageHtmlLink":"Merge pull request #9092 from alphagov/1169-republish-all-documents-w…"}},{"before":"d2856924e05d2b8557079ee6b8c7313ff931008f","after":"be120e3f69f138002eb4787cec973ebc7464530a","ref":"refs/heads/1169-republish-all-documents-with-pre-publication-editions-ui","pushedAt":"2024-05-30T13:55:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Add UI for republishing all docs with pre-pub eds\n\nAdd UI for republishing all documents with pre-publication editions","shortMessageHtmlLink":"Add UI for republishing all docs with pre-pub eds"}},{"before":"452e6d9691118f65d79f7fcf5cb62e307d36b02e","after":null,"ref":"refs/heads/1167-republish-all-documents-ui","pushedAt":"2024-05-30T13:52:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"}},{"before":"2ef926c5d849f06cf31a58d1f82bb4d88221f021","after":"85f994c891a028db711f44e4ed2647b71d209e7e","ref":"refs/heads/main","pushedAt":"2024-05-30T13:52:37.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Merge pull request #9091 from alphagov/1167-republish-all-documents-ui\n\nAdd UI for bulk republishing all documents","shortMessageHtmlLink":"Merge pull request #9091 from alphagov/1167-republish-all-documents-ui"}},{"before":"83d87e6f1e9321dad95b91e714a1001ecc67473d","after":null,"ref":"refs/heads/1167-abstract-republish-all-action","pushedAt":"2024-05-30T13:49:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWR7qnQA","startCursor":null,"endCursor":null}},"title":"Activity · alphagov/whitehall"}