Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need Accumulate #30

Open
hseeberger opened this issue Jul 7, 2016 · 4 comments
Open

Do we need Accumulate #30

hseeberger opened this issue Jul 7, 2016 · 4 comments

Comments

@hseeberger
Copy link

hseeberger commented Jul 7, 2016

According to the docs (I wrote): "This stage emits folded values like scan, but the first element emitted is not the zero value but the result of applying the given function to the given zero value and the first pushed element."

The same can be achieved with scan(...)(...).drop(1).

What do others think?

@hseeberger
Copy link
Author

@patriknw, @ktoso, (other Akka team members),
I suggest we get rid of this beautiful piece of code again, because it's simpler to use the two well known standard stages scan and drop in combination instead of introducing another one which is very similar to scan.
If you agree, I'd create a PR which deprecates Accumulate.

@hseeberger
Copy link
Author

@patriknw, @ktoso, @drewhk, any opinions?

@drewhk
Copy link
Member

drewhk commented Jul 22, 2016

The custom stage is more efficient, however it does not show good example to users (build from existing ops), so maybe better removing it.

@johanandren
Copy link
Member

I agree with deprecation and mention scan+drop as a replacement.

2m added a commit that referenced this issue Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants