Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akka-http 10.2.10 seems to have changed the semantics of the max-open-requests host connection pool configuration #4156

Open
jphelp32 opened this issue Sep 7, 2022 · 3 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:docs Issues related to the documentation

Comments

@jphelp32
Copy link

jphelp32 commented Sep 7, 2022

Change #4132 in 10.2.10 seems to have changed the semantics of the host connection pool max-open-requests configuration. Consider that N requests to a single host are accepted by Http().singleRequest() before a BufferOverflowException occurs. Prior to the mentioned change, N = max-open-connections. Now after this change, it appears that N = max-open-requests + max-connections. I've inquired about this #here. Is this a regression? or an intended behavior change?

@johanandren
Copy link
Member

Looks like it indeed may have been an unintended consequence of the fix in #4132

@jphelp32
Copy link
Author

@johanandren do you expect this to be fixed in any future 10.2.x release?

@johanandren
Copy link
Member

No, if we address this, I expect that it will be for the upcoming 10.4 series.

I understand it is annoying with this regression but we will only consider doing additional 10.2.x releases if critical or security issues is found.

@johanandren johanandren added t:docs Issues related to the documentation 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:docs Issues related to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants