Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add xsdata models #251

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!: add xsdata models #251

wants to merge 1 commit into from

Conversation

afuetterer
Copy link
Owner

@afuetterer afuetterer commented Jan 25, 2024

Refs: Fixes #126, fixes #152, fixes #111

Tasks

  • add xsdata models for "oai_pmh" xsd
  • add xsdata models for "oai_dc" xsd
  • add xsdata models for "oai_datacite" xsd
  • add xsdata models for "marcxml" xsd
  • add Response dataclass
  • add _build_response() helper function
  • add _parse_response() helper function
  • remove obsolete get_namespace() helper function
  • remove obsolete xml_to_dict() helper function
  • tests are passing
  • Fix OAI-PMH specific error handling #152
  • Add tests for error codes #111
  • Deleted status mixin for header and record
  • xsdata in readme
  • mock response needs content -> fixture with identify xml
  • Encoding was set on response
  • Add url attr to response
  • mypy is passing (3 issues remaining)
  • Example oai dc, datacite
  • update docs
    • customizing
    • check if returns and yields sections are displayed twice under api/client/
    • nested api reference for models
  • Show example of response without known metadata format, e.g. "arxiv"
  • Check if save to xml.code still works, uses raw

Refs:

@afuetterer afuetterer added type: feature New feature or request type: breaking Breaking Changes labels Jan 25, 2024
@afuetterer afuetterer added this to the 0.12 milestone Jan 25, 2024
@afuetterer afuetterer marked this pull request as draft January 25, 2024 12:54
@afuetterer afuetterer force-pushed the 126-xsdata-models branch 2 times, most recently from 18cf030 to a8a6e6e Compare January 25, 2024 13:30
@afuetterer afuetterer modified the milestones: 0.12, 0.13 Mar 16, 2024
@afuetterer afuetterer force-pushed the 126-xsdata-models branch 3 times, most recently from 1da89d4 to 4f7a02a Compare April 20, 2024 10:10
@afuetterer
Copy link
Owner Author

afuetterer commented Apr 21, 2024

Commit message draft:


feat!: add xsdata models

body

Refs: Fixes #126, fixes #152, fixes #111

@afuetterer afuetterer force-pushed the 126-xsdata-models branch 2 times, most recently from cddb11c to 753dfff Compare April 23, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Breaking Changes type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix OAI-PMH specific error handling Set up models as dataclasses with xsdata Add tests for error codes
1 participant