Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CholeskySolve extend SolveBase #1477

Open
brandonwillard opened this issue Mar 17, 2023 · 0 comments
Open

Make CholeskySolve extend SolveBase #1477

brandonwillard opened this issue Mar 17, 2023 · 0 comments
Assignees
@purna135
Labels
enhancement New feature or request Op implementation Involves the implementation of an Op refactor This issue involves refactoring

Comments

@brandonwillard
Copy link
Member

aesara.tensor.slinalg.CholeskySolve should extend SolveBase, if only because they both have the same default method implementations in multiple cases.
@brandonwillard brandonwillard added enhancement New feature or request refactor This issue involves refactoring Op implementation Involves the implementation of an Op labels Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purna135 purna135

Labels
enhancement New feature or request Op implementation Involves the implementation of an Op refactor This issue involves refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonwillard @purna135