Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Client policies and profiles have to be imported before clients. #985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Oh-tech
Copy link
Contributor

@Oh-tech Oh-tech commented Jan 30, 2024

What this PR does / why we need it:

The PR fixes the issue with the incorrect order of the imported realm resources

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #984

Special notes for your reviewer:

The PR is proposed with the assumption that it doesn't break the current behavior. Please let me know if the full case tests are required.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efc3bfa) 95.76% compared to head (aee88bc) 95.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #985   +/-   ##
=========================================
  Coverage     95.76%   95.76%           
  Complexity     1366     1366           
=========================================
  Files            80       80           
  Lines          4367     4367           
  Branches        491      491           
=========================================
  Hits           4182     4182           
  Misses           92       92           
  Partials         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The client policies are not applied on the imported clients.
1 participant