Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Slider values are truncated and divided by 1000 - when using values > 1000 #4415

Closed
1 task done
spdev3000 opened this issue May 8, 2024 · 3 comments · Fixed by #4417
Closed
1 task done
Assignees
Labels
bug Something isn't working Component: Slider triage An issue needing triage

Comments

@spdev3000
Copy link
Collaborator

spdev3000 commented May 8, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Slider

Expected behavior

When an editable slider is used with values > 1000 - those values should be displayed without truncation

<sp-slider 
        label="Slider with values > 1000" 
        min=0
        max=5000
        step="1"
        editable
        hide-stepper
      ></sp-slider>

Actual behavior

Using an editable slider with values > 1000 those values will be truncated by 1000 and rendered into input field

Screenshots

Screenshot 2024-05-08 at 11 06 26

Screen.Recording.2024-05-08.at.11.26.50.mp4

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://studio.webcomponents.dev/edit/MhXptBuyqtzL3DXAK3Cj/src/index.ts?p=stories
  2. Click on slider and adjust values to be greater than 999
  3. See input field renders values divided by 1000, so 1 instead of 1000 and 2 instead of 2000 are rendered, etc.

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@spdev3000 spdev3000 added bug Something isn't working triage An issue needing triage Component: Slider labels May 8, 2024
@spdev3000
Copy link
Collaborator Author

Probably was introduced with: #4263

@Westbrook
Copy link
Contributor

@blunteshwar please look at this with priority!

@spdev3000
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Slider triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants