Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "progress" properties in components should be called "value" #4222

Open
1 task done
larz0 opened this issue Mar 26, 2024 · 1 comment
Open
1 task done

[Bug]: "progress" properties in components should be called "value" #4222

larz0 opened this issue Mar 26, 2024 · 1 comment

Comments

@larz0
Copy link
Member

larz0 commented Mar 26, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Meter, Progress, and Progress Circle

Expected behavior

"progress" properties in Meter, Progress, and Progress Circle should be called "value" to match HTML and React Spectrum.

Actual behavior

"value" properties are currently called "progress".

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@larz0 larz0 added bug Something isn't working triage An issue needing triage labels Mar 26, 2024
@Westbrook
Copy link
Collaborator

Note than any changes looking to address this will need to support a deprecation period for the progress property in this elements and should also support a Dev Mode warning to support teams understanding that this usage needs to be updated in their applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants