Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][a11y]: Toast should have API for overriding the icon's alt text #3406

Open
1 task done
majornista opened this issue Jun 30, 2023 · 0 comments · May be fixed by #4159
Open
1 task done

[Bug][a11y]: Toast should have API for overriding the icon's alt text #3406

majornista opened this issue Jun 30, 2023 · 0 comments · May be fixed by #4159
Labels
a11y Issues related to accessibility bug Something isn't working Component: Toast I18n

Comments

@majornista
Copy link
Contributor

majornista commented Jun 30, 2023

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Toast

Expected behavior

It should be possible to override the string used as the label for the sp-icon element in the Shadow DOM, both for i18n purposes and for clarity, because sometimes an "Warning" is not an "Error."

This relates to #1975

Actual behavior

The alt text for the icon displayed in the "negative", "positive", and "info" Toast variants is hardcoded and cannot be overridden as "Error", "Success", and "Information" respectively.

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@majornista majornista added bug Something isn't working a11y Issues related to accessibility triage An issue needing triage labels Jun 30, 2023
@najikahalsema najikahalsema added Component: Toast I18n and removed triage An issue needing triage labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility bug Something isn't working Component: Toast I18n
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants