Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][a11y]: Coachmark subtle animation should support prefers-reduced-motion media query #3342

Closed
1 task done
majornista opened this issue Jun 20, 2023 · 4 comments
Closed
1 task done
Labels
a11y Issues related to accessibility bug Something isn't working Component: Coach Mark Spectrum CSS Bug Spectrum CSS

Comments

@majornista
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Coachmark

Expected behavior

Coachmark elements should not continue to animate when the user has prefers-reduced-motion as an operating system or browser setting.

Additional context:

Actual behavior

Coachmark continues to animate subtly despite the prefers-reduced-motion user preference.

The StoryDecorator contains some code to Reduce motion, but this is based on a [reduce-motion] attribute applied to the sp-theme element rather than respecting the prefers-reduced-motion media query.

:host([reduce-motion]) sp-theme {
${reduceMotionProperties}
}

Relevant issue filed with Spectrum-CSS: adobe/spectrum-css#1952

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

Steps to reproduce

  1. Using Chrome, go to https://opensource.adobe.com/spectrum-web-components/components/coachmark/
  2. Open Developer Tools > Rendering
  3. Under Emulate CSS media feature prefers-reduced-motion, select "prefers-reduced-motion: reduce"
  4. Screen shot of Developer Tools > Rendering panel with Emulate CSS media feature prefers-reduced-motion picker
Screen shot of  Developer Tools > Rendering panel with Emulate CSS media feature prefers-reduced-motion picker

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@majornista majornista added bug Something isn't working a11y Issues related to accessibility Spectrum CSS Bug Component: Coach Mark Spectrum CSS triage An issue needing triage labels Jun 20, 2023
@Westbrook
Copy link
Contributor

@pfulton what are you thoughts on adding support for this media query at the Spectrum CSS level?

@pfulton
Copy link
Collaborator

pfulton commented Jun 22, 2023

@Westbrook We're migrating Coach Mark as we speak, so this is one of the things on @jenndiaz's list to tackle with that work

@najikahalsema
Copy link
Collaborator

Related to #3666

@najikahalsema najikahalsema removed the triage An issue needing triage label Oct 5, 2023
@Westbrook
Copy link
Contributor

Closed by #3666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility bug Something isn't working Component: Coach Mark Spectrum CSS Bug Spectrum CSS
Projects
None yet
Development

No branches or pull requests

4 participants