Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabs' label's font-size has the wrong mod token #2585

Closed
lehelen19 opened this issue Mar 8, 2024 · 2 comments
Closed

tabs' label's font-size has the wrong mod token #2585

lehelen19 opened this issue Mar 8, 2024 · 2 comments
Assignees
@pfulton @castastrophe
Labels
bug Results from a bug in the CSS implementation

Comments

@lehelen19
Copy link

lehelen19 commented Mar 8, 2024 •
edited

Description

The tabs' label's font-size is set by var(--mod-tabs-font-weight) instead of a font size mod token.

Steps to reproduce

  1. Look at https://github.com/adobe/spectrum-css/blob/main/components/tabs/index.css#L436

Expected behavior

We should be able to set a mod token for font-size that doesn't change font-weight.

Screenshots

Environment

  • Version of the impacted component(s):
  • Browser(s) and OS(s):

Additional context
@lehelen19 lehelen19 added the bug Results from a bug in the CSS implementation label Mar 8, 2024
@castastrophe
Copy link
Collaborator

Great catch @lehelen19!

@pfulton
Copy link
Collaborator

pfulton commented May 1, 2024

Closed via #2596

@pfulton pfulton closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfulton pfulton

@castastrophe castastrophe

Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pfulton @castastrophe @lehelen19