Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@react-stately/flags stuck on old @swc/helpers? #6378

Closed
wojtekmaj opened this issue May 14, 2024 · 1 comment · Fixed by #6379
Closed

@react-stately/flags stuck on old @swc/helpers? #6378

wojtekmaj opened this issue May 14, 2024 · 1 comment · Fixed by #6379

Comments

@wojtekmaj
Copy link
Contributor

wojtekmaj commented May 14, 2024 •
edited

Provide your feedback here.

In #4642, @swc/helpers was updated to ^0.5.0 across all repos. In parallel, #4617 was developed, adding @react-stately/flags still using @swc/helpers@^0.4.14 as dependency.

Both PRs were merged at similar time.

🔦 Context

Consequently, installing react-aria-components installs causes not one, not two, but three versions of @swc/helpers to be installed:

  • 0.5.3 (latest matching ^0.5.0)
  • 0.4.36 (latest matching ^0.4.14)
  • 0.4.14 (referenced by 0.4.36 as legacy-swc-helpers)

💻 Code Sample

No response

Version

react-aria-components 1.1.1

What browsers are you seeing the problem on?

Other

If other, please specify

n/a

What operating system are you using?

macOS Sonoma
@wojtekmaj
Copy link
Contributor Author

In fact, looking at the source code of @react-stately/flags, I don't even see why it's a dependency at all 🤔 It's not used in any of the source files.

wojtekmaj added a commit to wojtekmaj/react-spectrum that referenced this issue May 14, 2024
@wojtekmaj
Remove @swc/helpers dependency from @react-stately/flags
1518123 
Closes adobe#6378
@wojtekmaj wojtekmaj mentioned this issue May 14, 2024
Merged
5 tasks
LFDanLu added a commit that referenced this issue May 20, 2024
@wojtekmaj @snowystinger @LFDanLu
Bump @swc/helpers in@react-stately/flags to match other packages (#…
43e54d1 
…6379)

* Remove `@swc/helpers` dependency from `@react-stately/flags`

Closes #6378

* Update package.json

Meet requirement for having a dep on swc helpers

---------

Co-authored-by: Robert Snow <snowystinger@gmail.com>
Co-authored-by: Daniel Lu <dl1644@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump @swc/helpers in@react-stately/flags to match other packages wojtekmaj/react-spectrum
1 participant
@wojtekmaj