Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useOverlay] Click Outside in Shadow-DOM context #3970

Closed
tnovas opened this issue Jan 27, 2023 · 3 comments
Closed

[useOverlay] Click Outside in Shadow-DOM context #3970

tnovas opened this issue Jan 27, 2023 · 3 comments

Comments

@tnovas
Copy link

tnovas commented Jan 27, 2023

The callback shouldCloseOnInteractOutside in useOverlay sends event.target, in Shadow-DOM context the event.target is Shadow-DOM and not the real point click, so, in this context the result is always click outside.
Could be changed to sends the event and not event.target?
This way we have more information like event.composedPath() and we check the real point click.

I look forward to your feedback.
Regards!

@LFDanLu
Copy link
Member

LFDanLu commented Jan 30, 2023

#1472 has some related discussion. Shadow DOM support is something we are definitely interested in, but we could use some help investigating what else is currently broken and what changes would need to be made to resolve them.

@LFDanLu
Copy link
Member

LFDanLu commented Feb 8, 2023

Closing as dupe

@theomessin
Copy link

theomessin commented May 15, 2023

@LFDanLu instead of closing every Shadow DOM related ticket in favour of #1472 I think it might be best to work incrementally and tackle issues one-by-one. #1472 has been around for 2 years and no progress has been made. #4526 addresses this particular issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants