Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Annotations feature for horizontal Bar Graphs #230

Open
arushi474 opened this issue Apr 7, 2024 · 6 comments
Open

Request for Annotations feature for horizontal Bar Graphs #230

arushi474 opened this issue Apr 7, 2024 · 6 comments
Labels
bug Something isn't working open for contribution Issue is available for contribution rsc:Bar

Comments

@arushi474
Copy link

Provide a general summary of the feature here

Annotations doesn't work for bar graph when orientation is horizontal.

馃 Expected Behavior?

image

馃拋 Possible Solution

You can enable/build the annotaions to work for horizontal bar graph.

馃敠 Context

image
As you can see it is enabled for verical bar graphs, But the same doesn't work for horizontal bar graphs.
As show below,
image

馃捇 Examples

This is the required behaviour

image

馃Б Your Company/Team

Adobe/Connect

@marshallpete
Copy link
Member

If you increase the height of your bar chart, do the annotations show up? We have something where if the width/height of the bar gets too small, the annotation won't show. Not saying it isn't a bug, just trying to troubleshoot a bit.

@arushi474
Copy link
Author

Hey @marshallpete can you mention the specific height/width at which the annotations are hiden? I did explored the same by putting some values for the height/width prop in chart but could not get it to show the annotations for horizontal bar graph.

@marshallpete
Copy link
Member

@arushi474 Sorry for the delay, I created another bug with more details and how to fix. I鈥檒l fix this one next week.
#268

@marshallpete marshallpete added bug Something isn't working open for contribution Issue is available for contribution rsc:Bar labels Apr 27, 2024
@marshallpete
Copy link
Member

Thanks again for the thorough details. You鈥檒l see in the other issue that the root cause is that we never properly setup annotations for horizontal bars. If the width of the bar is less than 48px, we hide the annotation. This should be updated so that with a horizontal bar, if the height of the bar is less than the height of the text, we hide the annotation.

@arushi474
Copy link
Author

Hey @marshallpete by when can I expect this to be fixed?

@marshallpete
Copy link
Member

I might have some time next week or it's open for contribution if you want to take a crack at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working open for contribution Issue is available for contribution rsc:Bar
Projects
None yet
Development

No branches or pull requests

2 participants